apple-sdk: support reading path set by xcode-select --switch#154
Closed
madsmtm wants to merge 1 commit intoindygreg:mainfrom
Closed
apple-sdk: support reading path set by xcode-select --switch#154madsmtm wants to merge 1 commit intoindygreg:mainfrom
xcode-select --switch#154madsmtm wants to merge 1 commit intoindygreg:mainfrom
Conversation
`xcode-select --switch PATH` creates a symlink at `/var/db/xcode_select_link`, which we can read to get the path of the current globally configured developer directory.
madsmtm
force-pushed
the
xcode-select-paths
branch
from
aa6e32f to
72c9fc7
Compare
Contributor
Author
|
I have since making this become aware that |
indygreg
approved these changes
Nov 2, 2024
Owner
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
This PR is perfect. Thank you very much!
I'll rebase the merge conflict locally and push outside of GitHub. The PR will be marked as closed instead of merged momentarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user can set the current developer directory globally by using
xcode-select --switch PATH.This creates a symlink at
/var/db/xcode_select_link, which we can read to get the path of the current globally configured developer directory. In the past, other files were created instead, so we also attempt to read those (we could probably omit this logic, but might as well include it for completeness).I'm fairly confident that this is the last thing needed for
SdkSearch::default()to perform exactly the same lookup asxcode-select --print-pathitself.See also rust-lang/rust#131433 where I implemented similar logic in
rustc.